Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional client/rpc tests #7

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 8, 2024

PR-Codex overview

The focus of this PR is to enhance timeout options handling, improve RPC error handling, and update CI workflow configurations.

Detailed summary

  • Added TimeoutType.Other with corresponding timeout handling
  • Improved error handling for deserialization and RPC requests
  • Updated CI workflow to trigger on PR opened and synchronized events

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.10%. Comparing base (90ec62a) to head (c832879).

Additional details and impacted files
@@            Coverage Diff            @@
##            main       #7      +/-   ##
=========================================
+ Coverage   8.57%   10.10%   +1.52%     
=========================================
  Files         34       33       -1     
  Lines       2366     2355      -11     
  Branches     221      219       -2     
=========================================
+ Hits         203      238      +35     
+ Misses      2145     2107      -38     
+ Partials      18       10       -8     
Flag Coverage Δ
integrationtests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit b440095 into main Apr 8, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/t-client-rpc branch April 8, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants